Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: Source/core/page/Page.cpp

Issue 898593002: DevTools: use per-LocalFrame instrumenting agents instead of per-Page ones. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index 901f784c897270eee7b68bfdd4cffbf536873f5f..90c96e47366a7e78bc26e3ac4f1662bf873a46b4 100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -93,12 +93,13 @@ void Page::networkStateChanged(bool online)
if (frame->isLocalFrame())
frames.append(toLocalFrame(frame));
}
- InspectorInstrumentation::networkStateChanged(page, online);
}
AtomicString eventName = online ? EventTypeNames::online : EventTypeNames::offline;
- for (unsigned i = 0; i < frames.size(); i++)
+ for (unsigned i = 0; i < frames.size(); i++) {
frames[i]->domWindow()->dispatchEvent(Event::create(eventName));
+ InspectorInstrumentation::networkStateChanged(frames[i].get(), online);
yurys 2015/02/03 06:44:00 Don't we expect this event to be dispatched once p
pfeldman 2015/02/03 07:09:16 Present plan is to attach to connected localframe
+ }
}
float deviceScaleFactor(LocalFrame* frame)

Powered by Google App Engine
This is Rietveld 408576698