DevTools: use per-LocalFrame instrumenting agents instead of per-Page ones.

Source/core/page/Page.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All Rights Reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 75 matching lines @@
 {
     WillBeHeapVector<RefPtrWillBeMember<LocalFrame>> frames;
 
     // Get all the frames of all the pages in all the page groups
     for (Page* page : allPages()) {
         for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
             // FIXME: There is currently no way to dispatch events to out-of-process frames.
             if (frame->isLocalFrame())
                 frames.append(toLocalFrame(frame));
         }
-        InspectorInstrumentation::networkStateChanged(page, online);
     }
 
     AtomicString eventName = online ? EventTypeNames::online : EventTypeNames::offline;
-    for (unsigned i = 0; i < frames.size(); i++)
+    for (unsigned i = 0; i < frames.size(); i++) {
         frames[i]->domWindow()->dispatchEvent(Event::create(eventName));
+        InspectorInstrumentation::networkStateChanged(frames[i].get(), online);

[yurys, 2015/02/03 06:44:00]

Don't we expect this event to be dispatched once per FrameHost?

[pfeldman, 2015/02/03 07:09:16]

Present plan is to attach to connected localframe hierarchies, so one frame host
might have multiple inspectors attached.

+    }
 }
 
 float deviceScaleFactor(LocalFrame* frame)
 {
     if (!frame)
         return 1;
     Page* page = frame->page();
     if (!page)
         return 1;
     return page->deviceScaleFactor();
@@ skipping 517 matching lines @@
     , inspectorClient(nullptr)
     , spellCheckerClient(nullptr)
 {
 }
 
 Page::PageClients::~PageClients()
 {
 }
 
 } // namespace blink