Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 898543002: Remove GLFence::CreateWithoutFlush (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GLFence::CreateWithoutFlush There is no callers for this anymore. Remove it and all the unnecessary code. BUG= Committed: https://crrev.com/574dc108b871f8be73c882a52fa9a8623d3c7537 Cr-Commit-Position: refs/heads/master@{#314627}

Patch Set 1 #

Patch Set 2 : remove flush event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -184 lines) Patch
M gpu/command_buffer/service/mailbox_manager_sync.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context.h View 1 3 chunks +0 lines, -24 lines 0 comments Download
M ui/gl/gl_context.cc View 1 3 chunks +0 lines, -27 lines 0 comments Download
M ui/gl/gl_fence.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/gl/gl_fence.cc View 2 chunks +20 lines, -33 lines 0 comments Download
M ui/gl/gl_fence_apple.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/gl/gl_fence_apple.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M ui/gl/gl_fence_arb.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/gl/gl_fence_arb.cc View 3 chunks +8 lines, -21 lines 0 comments Download
M ui/gl/gl_fence_egl.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/gl/gl_fence_egl.cc View 3 chunks +13 lines, -26 lines 0 comments Download
M ui/gl/gl_fence_nv.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/gl/gl_fence_nv.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
boliu
Not even 200 lines..
5 years, 10 months ago (2015-02-02 21:36:25 UTC) #2
boliu
Oops, meant to re-open this.
5 years, 10 months ago (2015-02-02 21:36:51 UTC) #3
no sievers
lgtm, thanks!
5 years, 10 months ago (2015-02-04 20:02:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898543002/20001
5 years, 10 months ago (2015-02-04 20:10:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 20:47:40 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:48:31 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/574dc108b871f8be73c882a52fa9a8623d3c7537
Cr-Commit-Position: refs/heads/master@{#314627}

Powered by Google App Engine
This is Rietveld 408576698