Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 898403003: [Android] Temporarily disable --warn-shared-textrel for mips (Closed)

Created:
5 years, 10 months ago by jdduke (slow)
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Temporarily disable --warn-shared-textrel for mips Mips builds hit this warning when linking the mesa library with libc++. Temporarily disable the warning until a permanent solution can be found. BUG=456380 Committed: https://crrev.com/c60179098e97dfda6c3fda982a028a27c9235805 Cr-Commit-Position: refs/heads/master@{#317709}

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M build/common.gypi View 1 2 chunks +11 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jdduke (slow)
thakis@: PTAL. Dirty, but at least it will unblock downstream mips builds while still preserving ...
5 years, 10 months ago (2015-02-07 01:10:02 UTC) #2
Nico
Is it understood what exactly is being warned about? I feel a bit uneasy about ...
5 years, 10 months ago (2015-02-07 01:15:11 UTC) #3
jdduke (slow)
On 2015/02/07 01:15:11, Nico wrote: > Is it understood what exactly is being warned about? ...
5 years, 10 months ago (2015-02-07 01:21:14 UTC) #4
Nico
lgtm, given that danalbert says that this should be fixed in newer toolchains. (I'll try ...
5 years, 10 months ago (2015-02-23 23:33:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898403003/20001
5 years, 10 months ago (2015-02-23 23:39:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 01:04:41 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:05:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c60179098e97dfda6c3fda982a028a27c9235805
Cr-Commit-Position: refs/heads/master@{#317709}

Powered by Google App Engine
This is Rietveld 408576698