Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: build/common.gypi

Issue 898403003: [Android] Temporarily disable --warn-shared-textrel for mips (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3604 matching lines...) Expand 10 before | Expand all | Expand 10 after
3615 }, 3615 },
3616 'defines': [ 3616 'defines': [
3617 '_DEBUG', 3617 '_DEBUG',
3618 ], 3618 ],
3619 'cflags': [ 3619 'cflags': [
3620 '-O>(debug_optimize)', 3620 '-O>(debug_optimize)',
3621 '-g', 3621 '-g',
3622 '-gdwarf-4', 3622 '-gdwarf-4',
3623 ], 3623 ],
3624 'conditions' : [ 3624 'conditions' : [
3625 ['OS=="android"', { 3625 ['OS=="android" and target_arch!="mipsel" and target_arch!="mips64 el"', {
3626 # TODO(jdduke) Re-enable on mips after resolving linking
3627 # issues with libc++ (crbug.com/456380).
3626 'ldflags': [ 3628 'ldflags': [
3627 # Warn in case of text relocations. 3629 # Warn in case of text relocations.
3628 '-Wl,--warn-shared-textrel', 3630 '-Wl,--warn-shared-textrel',
3629 ], 3631 ],
3630 }], 3632 }],
3631 ['OS=="android" and android_full_debug==0', { 3633 ['OS=="android" and android_full_debug==0', {
3632 # Some configurations are copied from Release_Base to reduce 3634 # Some configurations are copied from Release_Base to reduce
3633 # the binary size. 3635 # the binary size.
3634 'variables': { 3636 'variables': {
3635 'debug_optimize%': 's', 3637 'debug_optimize%': 's',
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
3708 ], 3710 ],
3709 }], 3711 }],
3710 ['OS=="android" and target_arch!="arm64"', { 3712 ['OS=="android" and target_arch!="arm64"', {
3711 # We don't omit frame pointers on arm64 since they are required 3713 # We don't omit frame pointers on arm64 since they are required
3712 # to correctly unwind stackframes which contain system library 3714 # to correctly unwind stackframes which contain system library
3713 # function frames (crbug.com/391706). 3715 # function frames (crbug.com/391706).
3714 'cflags': [ 3716 'cflags': [
3715 '-fomit-frame-pointer', 3717 '-fomit-frame-pointer',
3716 ] 3718 ]
3717 }], 3719 }],
3720 ['OS=="android" and target_arch!="mipsel" and target_arch!="mips64 el"', {
3721 # TODO(jdduke) Re-enable on mips after resolving linking
3722 # issues with libc++ (crbug.com/456380).
3723 'ldflags': [
3724 # Warn in case of text relocations.
3725 '-Wl,--warn-shared-textrel',
3726 ],
3727 }],
3718 ['OS=="android"', { 3728 ['OS=="android"', {
3719 'variables': { 3729 'variables': {
3720 'release_optimize%': 's', 3730 'release_optimize%': 's',
3721 }, 3731 },
3722 'ldflags': [
3723 # Warn in case of text relocations.
3724 '-Wl,--warn-shared-textrel',
3725 ],
3726 }], 3732 }],
3727 ['profiling==1', { 3733 ['profiling==1', {
3728 'cflags': [ 3734 'cflags': [
3729 '-fno-omit-frame-pointer', 3735 '-fno-omit-frame-pointer',
3730 '-g', 3736 '-g',
3731 ], 3737 ],
3732 'conditions' : [ 3738 'conditions' : [
3733 ['profiling_full_stack_frames==1', { 3739 ['profiling_full_stack_frames==1', {
3734 'cflags': [ 3740 'cflags': [
3735 '-fno-inline', 3741 '-fno-inline',
(...skipping 2155 matching lines...) Expand 10 before | Expand all | Expand 10 after
5891 # settings in target dicts. SYMROOT is a special case, because many other 5897 # settings in target dicts. SYMROOT is a special case, because many other
5892 # Xcode variables depend on it, including variables such as 5898 # Xcode variables depend on it, including variables such as
5893 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5899 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5894 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5900 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5895 # files to appear (when present) in the UI as actual files and not red 5901 # files to appear (when present) in the UI as actual files and not red
5896 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5902 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5897 # and therefore SYMROOT, needs to be set at the project level. 5903 # and therefore SYMROOT, needs to be set at the project level.
5898 'SYMROOT': '<(DEPTH)/xcodebuild', 5904 'SYMROOT': '<(DEPTH)/xcodebuild',
5899 }, 5905 },
5900 } 5906 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698