Issue 898013002: win: Fixes for minidump_file_writer_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898013002: win: Fixes for minidump_file_writer_test (Closed)

Created:
5 years, 10 months ago by scottmg

Modified:
5 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_test-6

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Fixes for minidump_file_writer_test - implicit conversion from time_t -> long - "exception_info" is a pseudo-keyword on MSVC related to SEH - disable warning about expected truncation R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8c74948ae589ca10ae79e73172cb915fdba9b6ec

Patch Set 1 #

Total comments: 2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	minidump/minidump_file_writer_test.cc	View		3 chunks	+10 lines, -3 lines	1 comment	Download
	M	snapshot/test/test_exception_snapshot.h	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/898013002/diff/1/minidump/minidump_file_writer_test.cc File minidump/minidump_file_writer_test.cc (right): https://codereview.chromium.org/898013002/diff/1/minidump/minidump_file_writer_test.cc#newcode292 minidump/minidump_file_writer_test.cc:292: #pragma warning(disable: 4309) // Truncation of constant value. ...

5 years, 10 months ago (2015-02-05 14:24:32 UTC) #2

scottmg

5 years, 10 months ago (2015-02-05 16:43:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c74948ae589ca10ae79e73172cb915fdba9b6ec (presubmit successful).

Expand Messages | Collapse Messages