win: Fixes for minidump_file_writer_test

minidump/minidump_file_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 223 matching lines @@
   ASSERT_NO_FATAL_FAILURE(VerifyMinidumpHeader(header, 1, 0));
   ASSERT_TRUE(directory);
 
   EXPECT_EQ(kStreamType, directory[0].StreamType);
   EXPECT_EQ(kStreamSize, directory[0].Location.DataSize);
   EXPECT_EQ(kStreamOffset, directory[0].Location.Rva);
 }
 
 TEST(MinidumpFileWriter, InitializeFromSnapshot_Basic) {
   const uint32_t kSnapshotTime = 0x4976043c;
-  const timeval kSnapshotTimeval = { implicit_cast<time_t>(kSnapshotTime), 0 };
+  const timeval kSnapshotTimeval = { static_cast<time_t>(kSnapshotTime), 0 };
 
   TestProcessSnapshot process_snapshot;
   process_snapshot.SetSnapshotTime(kSnapshotTimeval);
 
   auto system_snapshot = make_scoped_ptr(new TestSystemSnapshot());
   system_snapshot->SetCPUArchitecture(kCPUArchitectureX86_64);
   system_snapshot->SetOperatingSystem(SystemSnapshot::kOperatingSystemMacOSX);
   process_snapshot.SetSystem(system_snapshot.Pass());
 
   MinidumpFileWriter minidump_file_writer;
@@ skipping 25 matching lines @@
                   file_writer.string(), directory[3].Location));
 
   EXPECT_EQ(kMinidumpStreamTypeMemoryList, directory[4].StreamType);
   EXPECT_TRUE(MinidumpWritableAtLocationDescriptor<MINIDUMP_MEMORY_LIST>(
                   file_writer.string(), directory[4].Location));
 }
 
 TEST(MinidumpFileWriter, InitializeFromSnapshot_Exception) {
   // In a 32-bit environment, this will give a “timestamp out of range” warning,
   // but the test should complete without failure.
+#if defined(OS_WIN) && defined(ARCH_CPU_X86)
+#pragma warning(push)
+#pragma warning(disable: 4309)  // Truncation of constant value.

[Mark Mentovai, 2015/02/05 14:24:32]

If this comes up in many more places, perhaps we should have our own
TruncateCast.

+#endif  // OS_WIN && ARCH_CPU_X86
   const uint32_t kSnapshotTime = 0xfd469ab8;
-  const timeval kSnapshotTimeval = { implicit_cast<time_t>(kSnapshotTime), 0 };
+  const timeval kSnapshotTimeval = { static_cast<time_t>(kSnapshotTime), 0 };
+#if defined(OS_WIN) && defined(ARCH_CPU_X86)
+#pragma warning(pop)
+#endif  // OS_WIN && ARCH_CPU_X86
 
   TestProcessSnapshot process_snapshot;
   process_snapshot.SetSnapshotTime(kSnapshotTimeval);
 
   auto system_snapshot = make_scoped_ptr(new TestSystemSnapshot());
   system_snapshot->SetCPUArchitecture(kCPUArchitectureX86_64);
   system_snapshot->SetOperatingSystem(SystemSnapshot::kOperatingSystemMacOSX);
   process_snapshot.SetSystem(system_snapshot.Pass());
 
   auto thread_snapshot = make_scoped_ptr(new TestThreadSnapshot());
@@ skipping 43 matching lines @@
   EXPECT_TRUE(MinidumpWritableAtLocationDescriptor<MINIDUMP_MODULE_LIST>(
                   file_writer.string(), directory[4].Location));
 
   EXPECT_EQ(kMinidumpStreamTypeMemoryList, directory[5].StreamType);
   EXPECT_TRUE(MinidumpWritableAtLocationDescriptor<MINIDUMP_MEMORY_LIST>(
                   file_writer.string(), directory[5].Location));
 }
 
 TEST(MinidumpFileWriter, InitializeFromSnapshot_CrashpadInfo) {
   const uint32_t kSnapshotTime = 0x15393bd3;
-  const timeval kSnapshotTimeval = { implicit_cast<time_t>(kSnapshotTime), 0 };
+  const timeval kSnapshotTimeval = { static_cast<time_t>(kSnapshotTime), 0 };
 
   TestProcessSnapshot process_snapshot;
   process_snapshot.SetSnapshotTime(kSnapshotTimeval);
 
   auto system_snapshot = make_scoped_ptr(new TestSystemSnapshot());
   system_snapshot->SetCPUArchitecture(kCPUArchitectureX86_64);
   system_snapshot->SetOperatingSystem(SystemSnapshot::kOperatingSystemMacOSX);
   process_snapshot.SetSystem(system_snapshot.Pass());
 
   auto thread_snapshot = make_scoped_ptr(new TestThreadSnapshot());
@@ skipping 67 matching lines @@
   const MinidumpStreamType kStream1Type = static_cast<MinidumpStreamType>(0x4d);
   const uint8_t kStream1Value = 0xa5;
   auto stream1 = make_scoped_ptr(
       new TestStream(kStream1Type, kStream1Size, kStream1Value));
   ASSERT_DEATH(minidump_file.AddStream(stream1.Pass()), "already present");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad