Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897973002: Initialize V8 outside of PDFium. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, Will Harris
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initialize V8 outside of PDFium. This is similar to how we initialize ICU for V8 inside PDFium. BUG=455399 R=wfh@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1be20344622b3da0fa49d511254928c786154f6b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M fpdfsdk/include/javascript/IJavaScript.h View 3 chunks +1 line, -6 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 3 chunks +0 lines, -9 lines 0 comments Download
M pdfium.gyp View 1 chunk +4 lines, -5 lines 0 comments Download
M samples/pdfium_test.cc View 3 chunks +6 lines, -0 lines 2 comments Download
M samples/samples.gyp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jam
5 years, 10 months ago (2015-02-04 23:21:23 UTC) #2
Will Harris
lgtm but I'm no v8/pdfium expert. https://codereview.chromium.org/897973002/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/897973002/diff/1/samples/pdfium_test.cc#newcode536 samples/pdfium_test.cc:536: FPDF_DestroyLibrary(); is a ...
5 years, 10 months ago (2015-02-04 23:56:45 UTC) #4
jam
https://codereview.chromium.org/897973002/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/897973002/diff/1/samples/pdfium_test.cc#newcode536 samples/pdfium_test.cc:536: FPDF_DestroyLibrary(); On 2015/02/04 23:56:45, Will Harris wrote: > is ...
5 years, 10 months ago (2015-02-04 23:59:07 UTC) #5
jam
5 years, 10 months ago (2015-02-05 00:04:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1be20344622b3da0fa49d511254928c786154f6b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698