fpdfsdk/include/javascript/IJavaScript.h - Issue 897973002: Initialize V8 outside of PDFium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/IJavaScript.h

Issue 897973002: Initialize V8 outside of PDFium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/IJavaScript.h

diff --git a/fpdfsdk/include/javascript/IJavaScript.h b/fpdfsdk/include/javascript/IJavaScript.h

index 8ea9a4e89f158afe60df589e66a862da48034728..9ae0329e30cecf6852504cbfb23779745f537c18 100644

--- a/fpdfsdk/include/javascript/IJavaScript.h

+++ b/fpdfsdk/include/javascript/IJavaScript.h

@@ -7,10 +7,6 @@

#ifndef _IJAVASCRIPT_H_

#define _IJAVASCRIPT_H_

-namespace v8 {

-class Platform;

class IFXJS_Context

{

public:

@@ -99,7 +95,7 @@ class CJS_GlobalData;

class CJS_RuntimeFactory

{

public:

- CJS_RuntimeFactory():m_bInit(FALSE),m_nRef(0),m_pGlobalData(NULL),m_nGlobalDataCount(0),m_platform(NULL) {}

+ CJS_RuntimeFactory():m_bInit(FALSE),m_nRef(0),m_pGlobalData(NULL),m_nGlobalDataCount(0) {}

~CJS_RuntimeFactory();

IFXJS_Runtime* NewJSRuntime(CPDFDoc_Environment* pApp);

void DeleteJSRuntime(IFXJS_Runtime* pRuntime);

@@ -113,7 +109,6 @@ private:

int m_nRef;

CJS_GlobalData* m_pGlobalData;

FX_INT32 m_nGlobalDataCount;

- v8::Platform* m_platform;

};

#endif //_IJAVASCRIPT_H_

« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | samples/pdfium_test.cc » ('J')