Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3471)

Unified Diff: chrome/browser/android/service_tab_launcher.h

Issue 897673002: First step in enabling creating tabs without an Activity on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a-base-mounir
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/service_tab_launcher.h
diff --git a/chrome/browser/android/service_tab_launcher.h b/chrome/browser/android/service_tab_launcher.h
new file mode 100644
index 0000000000000000000000000000000000000000..b2fe5cd17c20bd2c178411c5a21555682335b1ec
--- /dev/null
+++ b/chrome/browser/android/service_tab_launcher.h
@@ -0,0 +1,51 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_SERVICE_TAB_LAUNCHER_H_
+#define CHROME_BROWSER_ANDROID_SERVICE_TAB_LAUNCHER_H_
+
+#include "base/android/jni_android.h"
+#include "base/callback_forward.h"
+#include "base/memory/singleton.h"
+
+namespace content {
+class BrowserContext;
+struct OpenURLParams;
+class WebContents;
+}
+
+namespace chrome {
+namespace android {
+
+// Launcher for creating new tabs on Android from a background service, where
+// there may not necessarily be an Activity or a tab model at all.
+class ServiceTabLauncher {
+ public:
+ // Returns the singleton instance of the service tab launcher.
+ static ServiceTabLauncher* GetInstance();
+
+ // Launches a new tab when we're in a Service rather than in an Activity.
+ // |callback| will be invoked with the resulting content::WebContents* when
+ // the tab is avialable. This method must only be called from the UI thread.
+ void LaunchTab(content::BrowserContext* browser_context,
mlamouri (slow - plz ping) 2015/02/09 12:07:37 nit: why not OpenURL() to keep symmetry with Conte
Peter Beverloo 2015/02/10 17:49:37 One opens a URL, but launches a tab. This was a su
mlamouri (slow - plz ping) 2015/02/11 13:50:23 I will not block on that but given that we pass Op
Peter Beverloo 2015/02/11 16:18:26 Good point. Applied per the other comment. I'll ma
+ const content::OpenURLParams& params,
+ base::Callback<void(content::WebContents*)> callback);
+
+ static bool RegisterServiceTabLauncher(JNIEnv* env);
+
+ private:
+ friend struct DefaultSingletonTraits<ServiceTabLauncher>;
+
+ ServiceTabLauncher();
+ ~ServiceTabLauncher();
+
+ base::android::ScopedJavaGlobalRef<jobject> java_object_;
+
+ DISALLOW_COPY_AND_ASSIGN(ServiceTabLauncher);
+};
+
+} // namespace android
+} // namespace chrome
+
+#endif // CHROME_BROWSER_ANDROID_SERVICE_TAB_LAUNCHER_H_

Powered by Google App Engine
This is Rietveld 408576698