Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897633004: [Password Generation] Logging for release builds (Closed)

Created:
5 years, 10 months ago by Garrett Casto
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Logging for release builds There have been a few reported cases of generation not triggering when it should. This changes the necessary logging from DVLOG to VLOG to help in debugging these problems. BUG=455869 Committed: https://crrev.com/e8f2e7f382bf2c9dc4dea081a02d45d358f5b9ac Cr-Commit-Position: refs/heads/master@{#315817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M components/autofill/content/renderer/password_generation_agent.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_generation_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Garrett Casto
5 years, 10 months ago (2015-02-11 00:13:25 UTC) #2
please use gerrit instead
lgtm
5 years, 10 months ago (2015-02-11 00:35:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897633004/1
5 years, 10 months ago (2015-02-11 18:37:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 19:46:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 19:47:06 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e8f2e7f382bf2c9dc4dea081a02d45d358f5b9ac
Cr-Commit-Position: refs/heads/master@{#315817}

Powered by Google App Engine
This is Rietveld 408576698