Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 897633004: [Password Generation] Logging for release builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_download_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index 2e141b8c5da8e2589266ee0af10702ad3526b40e..02776c34e46726bd5d4d2eb6a7b6204cb3be2fed 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -107,7 +107,7 @@ PasswordGenerationAgent::PasswordGenerationAgent(
generation_popup_shown_(false),
editing_popup_shown_(false),
enabled_(password_generation::IsPasswordGenerationEnabled()) {
- DVLOG(2) << "Password Generation is " << (enabled_ ? "Enabled" : "Disabled");
+ VLOG(2) << "Password Generation is " << (enabled_ ? "Enabled" : "Disabled");
}
PasswordGenerationAgent::~PasswordGenerationAgent() {}
@@ -189,7 +189,7 @@ void PasswordGenerationAgent::FindPossibleGenerationForm() {
scoped_ptr<PasswordForm> password_form(
CreatePasswordForm(forms[i], nullptr));
if (!password_form.get()) {
- DVLOG(2) << "Skipping form as it would not be saved";
+ VLOG(2) << "Skipping form as it would not be saved";
continue;
}
@@ -208,7 +208,7 @@ void PasswordGenerationAgent::FindPossibleGenerationForm() {
}
if (!possible_account_creation_forms_.empty()) {
- DVLOG(2) << possible_account_creation_forms_.size()
+ VLOG(2) << possible_account_creation_forms_.size()
<< " possible account creation forms deteceted";
DetermineGenerationElement();
}
@@ -220,7 +220,7 @@ bool PasswordGenerationAgent::ShouldAnalyzeDocument() const {
blink::WebSecurityOrigin origin =
render_frame()->GetWebFrame()->document().securityOrigin();
if (!origin.canAccessPasswordManager()) {
- DVLOG(1) << "No PasswordManager access";
+ VLOG(1) << "No PasswordManager access";
return false;
}
@@ -269,14 +269,14 @@ void PasswordGenerationAgent::OnAccountCreationFormsDetected(
void PasswordGenerationAgent::DetermineGenerationElement() {
if (generation_form_data_) {
- DVLOG(2) << "Account creation form already found";
+ VLOG(2) << "Account creation form already found";
return;
}
// Make sure local heuristics have identified a possible account creation
// form.
if (possible_account_creation_forms_.empty()) {
- DVLOG(2) << "Local hueristics have not detected a possible account "
+ VLOG(2) << "Local hueristics have not detected a possible account "
<< "creation form";
return;
}
@@ -285,22 +285,22 @@ void PasswordGenerationAgent::DetermineGenerationElement() {
PasswordForm* possible_password_form = possible_form_data.form.get();
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kLocalHeuristicsOnlyForPasswordGeneration)) {
- DVLOG(2) << "Bypassing additional checks.";
+ VLOG(2) << "Bypassing additional checks.";
} else if (!ContainsURL(not_blacklisted_password_form_origins_,
possible_password_form->origin)) {
- DVLOG(2) << "Have not received confirmation that password form isn't "
+ VLOG(2) << "Have not received confirmation that password form isn't "
<< "blacklisted";
continue;
} else if (!ContainsForm(generation_enabled_forms_,
*possible_password_form)) {
// Note that this message will never be sent if this feature is disabled
// (e.g. Password saving is disabled).
- DVLOG(2) << "Have not received confirmation from Autofill that form is "
+ VLOG(2) << "Have not received confirmation from Autofill that form is "
<< "used for account creation";
continue;
}
- DVLOG(2) << "Password generation eligible form found";
+ VLOG(2) << "Password generation eligible form found";
generation_form_data_.reset(
new AccountCreationFormData(possible_form_data.form,
possible_form_data.password_elements));
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_download_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698