Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 897583002: Ignore updates to app list Most Likely apps when animating off the start page. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@doodle_static
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore updates to app list Most Likely apps when animating off the start page. This CL ignores updates to and disables the Most Likely apps when the page is animating away from the start page. This prevents the apps from disappearing due to a search being initiated. BUG=454667 Committed: https://crrev.com/275a5968398c78272e7a3eb74887c47136e5f7ca Cr-Commit-Position: refs/heads/master@{#314746}

Patch Set 1 #

Patch Set 2 : fix_test #

Total comments: 1

Patch Set 3 : rebase onto https://codereview.chromium.org/896063002 #

Patch Set 4 : address_comment #

Patch Set 5 : rebaseagain #

Patch Set 6 : auto* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M ui/app_list/views/app_list_view_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 1 2 3 4 5 5 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
calamity
5 years, 10 months ago (2015-02-04 03:48:50 UTC) #2
Matt Giuca
lgtm https://codereview.chromium.org/897583002/diff/10002/ui/app_list/views/start_page_view.cc File ui/app_list/views/start_page_view.cc (right): https://codereview.chromium.org/897583002/diff/10002/ui/app_list/views/start_page_view.cc#newcode240 ui/app_list/views/start_page_view.cc:240: for (size_t i = 0; i < search_result_tile_views_.size(); ...
5 years, 10 months ago (2015-02-04 05:55:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897583002/90001
5 years, 10 months ago (2015-02-05 03:05:21 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 10 months ago (2015-02-05 04:02:17 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:04:23 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/275a5968398c78272e7a3eb74887c47136e5f7ca
Cr-Commit-Position: refs/heads/master@{#314746}

Powered by Google App Engine
This is Rietveld 408576698