Ignore updates to app list Most Likely apps when animating off the start page.

ui/app_list/views/start_page_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/start_page_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/app_list/app_list_constants.h"
 #include "ui/app_list/app_list_item.h"
 #include "ui/app_list/app_list_model.h"
@@ skipping 50 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(SearchBoxSpacerView);
 };
 
 }  // namespace
 
 // A container that holds the start page recommendation tiles and the all apps
 // tile.
 class StartPageView::StartPageTilesContainer
     : public SearchResultContainerView {
  public:
-  explicit StartPageTilesContainer(AllAppsTileItemView* all_apps_button);
+  StartPageTilesContainer(ContentsView* contents_view,
+                          AllAppsTileItemView* all_apps_button);
   ~StartPageTilesContainer() override;
 
   TileItemView* GetTileItemView(size_t index);
 
   const std::vector<SearchResultTileItemView*>& tile_views() const {
     return search_result_tile_views_;
   }
 
   AllAppsTileItemView* all_apps_button() { return all_apps_button_; }
 
   // Overridden from SearchResultContainerView:
   int Update() override;
   void UpdateSelectedIndex(int old_selected, int new_selected) override;
   void OnContainerSelected(bool from_bottom) override;
 
  private:
+  ContentsView* contents_view_;
+
   std::vector<SearchResultTileItemView*> search_result_tile_views_;
   AllAppsTileItemView* all_apps_button_;
 
   DISALLOW_COPY_AND_ASSIGN(StartPageTilesContainer);
 };
 
 StartPageView::StartPageTilesContainer::StartPageTilesContainer(
+    ContentsView* contents_view,
     AllAppsTileItemView* all_apps_button)
-    : all_apps_button_(all_apps_button) {
+    : contents_view_(contents_view), all_apps_button_(all_apps_button) {
   views::BoxLayout* tiles_layout_manager =
       new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, kTileSpacing);
   tiles_layout_manager->set_main_axis_alignment(
       views::BoxLayout::MAIN_AXIS_ALIGNMENT_CENTER);
   SetLayoutManager(tiles_layout_manager);
   set_background(
       views::Background::CreateSolidBackground(kLabelBackgroundColor));
 
   // Add SearchResultTileItemViews to the container.
   for (size_t i = 0; i < kNumStartPageTiles; ++i) {
@@ skipping 15 matching lines @@
 TileItemView* StartPageView::StartPageTilesContainer::GetTileItemView(
     size_t index) {
   DCHECK_GT(kNumStartPageTiles + 1, index);
   if (index == kNumStartPageTiles)
     return all_apps_button_;
 
   return search_result_tile_views_[index];
 }
 
 int StartPageView::StartPageTilesContainer::Update() {
+  // Ignore updates and disable buttons when transitioning to a different
+  // state.
+  if (contents_view_->GetActiveState() != AppListModel::STATE_START) {
+    for (auto* view : search_result_tile_views_)
+      view->SetEnabled(false);
+
+    return num_results();
+  }
+
   std::vector<SearchResult*> display_results =
       AppListModel::FilterSearchResultsByDisplayType(
           results(), SearchResult::DISPLAY_RECOMMENDATION, kNumStartPageTiles);
 
   // Update the tile item results.
   for (size_t i = 0; i < search_result_tile_views_.size(); ++i) {
-    SearchResult* item = nullptr;
+    SearchResult* item = NULL;
     if (i < display_results.size())
       item = display_results[i];
     search_result_tile_views_[i]->SetSearchResult(item);
+    search_result_tile_views_[i]->SetEnabled(true);
   }
 
   Layout();
   parent()->Layout();
   // Add 1 to the results size to account for the all apps button.
   return display_results.size() + 1;
 }
 
 void StartPageView::StartPageTilesContainer::UpdateSelectedIndex(
     int old_selected,
@@ skipping 11 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // StartPageView implementation:
 StartPageView::StartPageView(AppListMainView* app_list_main_view,
                              AppListViewDelegate* view_delegate)
     : app_list_main_view_(app_list_main_view),
       view_delegate_(view_delegate),
       search_box_spacer_view_(new SearchBoxSpacerView(
           app_list_main_view->search_box_view()->GetPreferredSize())),
       instant_container_(new views::View),
-      tiles_container_(new StartPageTilesContainer(new AllAppsTileItemView(
-          app_list_main_view_->contents_view(),
-          view_delegate_->GetModel()->top_level_item_list()))) {
+      tiles_container_(new StartPageTilesContainer(
+          app_list_main_view->contents_view(),
+          new AllAppsTileItemView(
+              app_list_main_view_->contents_view(),
+              view_delegate_->GetModel()->top_level_item_list()))) {
   // The view containing the start page WebContents and SearchBoxSpacerView.
   InitInstantContainer();
   AddChildView(instant_container_);
 
   // The view containing the start page tiles.
   AddChildView(tiles_container_);
 
   tiles_container_->SetResults(view_delegate_->GetModel()->results());
   Reset();
 }
@@ skipping 124 matching lines @@
   }
 
   custom_page_clickzone->Hide();
 }
 
 TileItemView* StartPageView::GetTileItemView(size_t index) {
   return tiles_container_->GetTileItemView(index);
 }
 
 }  // namespace app_list