Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 897573002: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (1/3) (Closed)

Created:
5 years, 10 months ago by nhiroki
Modified:
5 years, 10 months ago
Reviewers:
kinuko, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (1/3) This series of CLs changes a call sequence of unregister API. unregister API was originally exposed on ServiceWorkerContainer interface[1], so that's still processed via WebServiceWorkerProvider like register() and getRegistration(). But the API is now exposed on ServiceWorkerRegistration interface[2] and it seems more natural that WebServiceWorkerRegistration processes it. [1] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container [2] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj CL dependency: (1) Blink: THIS PATCH (2) Chromium: https://codereview.chromium.org/896533004/ (3) Blink: https://codereview.chromium.org/896433005/ BUG=452910 TEST=n/a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M public/platform/WebServiceWorkerProvider.h View 1 chunk +2 lines, -1 line 0 comments Download
M public/platform/WebServiceWorkerRegistration.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nhiroki
Hi kinuko@, can you review this? My final goal is to support SWRegistration.unregister() on SWGlobalScope. ...
5 years, 10 months ago (2015-02-03 05:29:18 UTC) #2
kinuko
lgtm
5 years, 10 months ago (2015-02-03 07:51:00 UTC) #3
nhiroki
+mkwst@, can you review this? Thanks!
5 years, 10 months ago (2015-02-03 07:53:17 UTC) #6
nhiroki
5 years, 10 months ago (2015-02-03 13:02:41 UTC) #7
kinuko@ pointed out that there are crashable cases on the 2nd CL, so I decided
to drop this series of CLs and will make new ones to support WebSWProvider on
SWGlobalScope.

Powered by Google App Engine
This is Rietveld 408576698