public/platform/WebServiceWorkerProvider.h - Issue 897573002: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerProvider.h

Issue 897573002: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebServiceWorkerProvider.h

diff --git a/public/platform/WebServiceWorkerProvider.h b/public/platform/WebServiceWorkerProvider.h

index 3734599f1dfc725c956da259dd71e489e73a1952..8ddeeacbb3b788390eba4a5172ea85b57f8a1e6e 100644

--- a/public/platform/WebServiceWorkerProvider.h

+++ b/public/platform/WebServiceWorkerProvider.h

@@ -58,7 +58,8 @@ public:

virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }

- // Unregisters the ServiceWorker for a given scope.

+ // FIXME: Remove this after WebServiceWorkerRegistration.unregister() is

+ // implemented (http://crbug.com/452910).

virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerUnregistrationCallbacks*) { }

virtual void getRegistration(const WebURL& documentURL, WebServiceWorkerGetRegistrationCallbacks*) { }

« no previous file with comments | « no previous file | public/platform/WebServiceWorkerRegistration.h » ('j') | no next file with comments »