Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 897563002: Unify the three places that patch font loading for PDFium on Windows. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, dcheng, kinuko+watch, aandrey+blink_chromium.org, jsbell+serviceworker_chromium.org, vsevik, mlamouri+watch-geolocation_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, michaeln, serviceworker-reviews, mcasas+watch_chromium.org, yurys, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, wjia+watch_chromium.org, kinuko+fileapi, pfeldman, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify the three places that patch font loading for PDFium on Windows. This also removed the code from content, which doesn't belong there because it's for a feature in Chrome. In order to implement this in a unified way, I needed to create a public interface around ChildThread. A lot of the change is updating callers of ChildThread to use ChildThreadImpl instead. BUG=448473 Committed: https://crrev.com/8a021512a24f87d3b1723f260e0380b874f3b9eb Cr-Commit-Position: refs/heads/master@{#314367}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -1405 lines) Patch
M chrome/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +9 lines, -5 lines 0 comments Download
A + chrome/child/BUILD.gn View 1 chunk +4 lines, -6 lines 0 comments Download
A chrome/child/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/child/pdf_child_init.h View 1 chunk +6 lines, -2 lines 0 comments Download
A chrome/child/pdf_child_init.cc View 1 2 3 4 1 chunk +73 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_android.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/chrome_child.gypi View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 3 chunks +0 lines, -57 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/printing_handler.cc View 3 chunks +0 lines, -46 lines 1 comment Download
M content/app/android/child_process_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_histogram_message_filter.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_process.h View 4 chunks +6 lines, -6 lines 0 comments Download
M content/child/child_process.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/child_shared_bitmap_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D content/child/child_thread.h View 1 chunk +0 lines, -302 lines 0 comments Download
D content/child/child_thread.cc View 1 chunk +0 lines, -629 lines 0 comments Download
A + content/child/child_thread_impl.h View 7 chunks +21 lines, -11 lines 2 comments Download
A + content/child/child_thread_impl.cc View 19 chunks +52 lines, -38 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/child/notifications/notification_image_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/quota_dispatcher.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/child/service_worker/service_worker_provider_context.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/shared_worker_devtools_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/thread_safe_sender.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/thread_safe_sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/threaded_data_provider.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M content/child/webblobregistry_impl.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M content/child/webmessageportchannel_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/websocket_bridge.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/content_child.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/plugin/plugin_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 3 chunks +12 lines, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 7 chunks +4 lines, -64 lines 0 comments Download
A content/public/child/child_thread.h View 1 chunk +37 lines, -0 lines 0 comments Download
M content/public/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/render_thread.h View 3 chunks +2 lines, -15 lines 0 comments Download
A content/public/utility/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/utility/utility_thread.h View 2 chunks +2 lines, -16 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_compositor_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_file_system_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/ppb_broker_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.h View 5 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 9 chunks +11 lines, -19 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/renderer_clipboard_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/embedded_worker_context_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_devtools_agent.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/shared_worker_repository.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.h View 4 chunks +12 lines, -7 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
5 years, 10 months ago (2015-02-03 07:09:13 UTC) #3
scottmg
It's too bad it's such a big change for something we can hopefully remove once ...
5 years, 10 months ago (2015-02-03 17:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897563002/120001
5 years, 10 months ago (2015-02-03 18:11:53 UTC) #6
jam
https://codereview.chromium.org/897563002/diff/120001/content/child/child_thread_impl.h File content/child/child_thread_impl.h (right): https://codereview.chromium.org/897563002/diff/120001/content/child/child_thread_impl.h#newcode63 content/child/child_thread_impl.h:63: virtual public ChildThread { On 2015/02/03 17:52:06, scottmg wrote: ...
5 years, 10 months ago (2015-02-03 18:13:04 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 10 months ago (2015-02-03 18:16:40 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 18:17:32 UTC) #9
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8a021512a24f87d3b1723f260e0380b874f3b9eb
Cr-Commit-Position: refs/heads/master@{#314367}

Powered by Google App Engine
This is Rietveld 408576698