Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: trunk/src/chrome/browser/feedback/tracing_manager.h

Issue 89753004: Revert 237280 "Remove TraceController" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/feedback/tracing_manager.h
===================================================================
--- trunk/src/chrome/browser/feedback/tracing_manager.h (revision 237451)
+++ trunk/src/chrome/browser/feedback/tracing_manager.h (working copy)
@@ -12,18 +12,13 @@
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "content/public/browser/trace_subscriber.h"
-namespace base {
-
-class RefCountedString;
-class FilePath;
-
-}
// Callback used for getting the output of a trace.
typedef base::Callback<void(scoped_refptr<base::RefCountedString> trace_data)>
TraceDataCallback;
-// This class is used to manage performance metrics that can be attached to
+// This class is used to manage performance meterics that can be attached to
// feedback reports. This class is a Singleton that is owned by the preference
// system. It should only be created when it is enabled, and should only be
// accessed elsewhere via Get().
@@ -33,7 +28,7 @@
// version of the performance data. That data can then be requested via
// GetTraceData(). When the data is no longer needed, it should be discarded
// via DiscardTraceData().
-class TracingManager {
+class TracingManager : public content::TraceSubscriber {
public:
virtual ~TracingManager();
@@ -55,10 +50,17 @@
void DiscardTraceData(int id);
private:
+ void StartTracing();
+
+ // content::TraceSubscriber overrides
+ virtual void OnEndTracingComplete() OVERRIDE;
+ virtual void OnTraceDataCollected(
+ const scoped_refptr<base::RefCountedString>& trace_fragment) OVERRIDE;
+
TracingManager();
- void StartTracing();
- void OnTraceDataCollected(const base::FilePath& path);
+ // Data being collected from the current trace.
+ std::string data_;
// ID of the trace that is being collected.
int current_trace_id_;
« no previous file with comments | « trunk/src/chrome/browser/feedback/feedback_util.cc ('k') | trunk/src/chrome/browser/feedback/tracing_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698