Issue 8974033: Fix the GURL change [compile error, two small changes to make things safe while

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8974033: Fix the GURL change [compile error, two small changes to make things safe while (Closed)

Created:
8 years, 11 months ago by ericu

Modified:
8 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

Fix the GURL change [compile error, two small changes to make things safe while the rest of the changes aren't in yet].

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -24 lines)			Patch
M	src/gurl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/url_canon_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/url_parse.cc	View	2 chunks	+23 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

ericu

Brett, here's what looks like a fix for the build breakage, and two other issues.

8 years, 11 months ago (2012-01-05 00:29:29 UTC) #1

Checked in as googleurl@167, I did not roll deps.