Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: mojo/public/bindings/js/handle.cc

Issue 89723002: Convert the rest of the functions in core.cc to use CreateFunctionTemplate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase+comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/bindings/js/handle.h ('k') | mojo/public/bindings/js/waiting_callback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/bindings/js/handle.cc
diff --git a/mojo/public/bindings/js/handle.cc b/mojo/public/bindings/js/handle.cc
index 3a601fe890ea625dd6bc2f9c5c473ae57dc41f93..b0ef697ce99ed172141ee011c40f323959518361 100644
--- a/mojo/public/bindings/js/handle.cc
+++ b/mojo/public/bindings/js/handle.cc
@@ -11,9 +11,10 @@ v8::Handle<v8::Value> Converter<mojo::Handle>::ToV8(v8::Isolate* isolate,
return Converter<MojoHandle>::ToV8(isolate, val.value());
}
-bool Converter<mojo::Handle>::FromV8(v8::Handle<v8::Value> val,
+bool Converter<mojo::Handle>::FromV8(v8::Isolate* isolate,
+ v8::Handle<v8::Value> val,
mojo::Handle* out) {
- return Converter<MojoHandle>::FromV8(val, out->mutable_value());
+ return Converter<MojoHandle>::FromV8(isolate, val, out->mutable_value());
}
} // namespace gin
« no previous file with comments | « mojo/public/bindings/js/handle.h ('k') | mojo/public/bindings/js/waiting_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698