Issue 897213005: Remove misleading comment in CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 897213005: Remove misleading comment in CSSPropertyParser (Closed)

Created:
5 years, 10 months ago by rwlbuis

Modified:
5 years, 10 months ago

Reviewers:
pdr.

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove misleading comment in CSSPropertyParser All SVG code paths call parseColor/parseColorFromValue with the default for acceptQuirkyColors, which causes strict parsing in parseColorFromValue. NOTRY=true BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189935

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/core/css/parser/CSSPropertyParser.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897213005/1

5 years, 10 months ago (2015-02-10 23:51:37 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-10 23:52:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189935

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages