Source/core/css/parser/CSSPropertyParser.cpp - Issue 897213005: Remove misleading comment in CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 897213005: Remove misleading comment in CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index c557b59ae6d61a6f7f0695165f1351342f490ec3..599d299e6335f7d45ddb302ded51cdd55ccf01a8 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -5352,7 +5352,6 @@ bool CSSPropertyParser::parseColorFromValue(CSSParserValue* value, RGBA32& c, bo

if (acceptQuirkyColors && value->unit == CSSPrimitiveValue::CSS_NUMBER

&& value->fValue >= 0. && value->fValue < 1000000.) {

String str = String::format("%06d", static_cast<int>((value->fValue+.5)));

- // FIXME: This should be strict parsing for SVG as well.

if (!fastParseColor(c, str, !acceptQuirkyColors))

return false;

} else if (acceptQuirkyColors && value->unit == CSSParserValue::DimensionList) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »