Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 896973005: MIPS: [turbofan] Initial support for Switch. (Closed)

Created:
5 years, 10 months ago by akos.palfi.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Initial support for Switch. Port feb2890711e8072a9550abb89621929816fc9699 Original commit message: Adds Switch and Case operators to TurboFan and handles them appropriately in instruction selection and code generation. BUG= Committed: https://crrev.com/0b692450c32f42f3859c4e0750310fcc225a29b9 Cr-Commit-Position: refs/heads/master@{#26535}

Patch Set 1 #

Patch Set 2 : Fix debug mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 10 months ago (2015-02-10 03:16:10 UTC) #2
paul.l...
LGTM. This un-breaks the build, but the MIPS dd implementation still has bugs, so related ...
5 years, 10 months ago (2015-02-10 03:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896973005/20001
5 years, 10 months ago (2015-02-10 03:26:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 04:02:28 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 04:03:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b692450c32f42f3859c4e0750310fcc225a29b9
Cr-Commit-Position: refs/heads/master@{#26535}

Powered by Google App Engine
This is Rietveld 408576698