Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 896913002: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
boliu
CC:
android-webview-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=boliu@chromium.org Committed: https://crrev.com/7800168df87639c5f5fc758ce4159fee12600353 Cr-Commit-Position: refs/heads/master@{#314471}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -79 lines) Patch
M android_webview/browser/net/android_stream_reader_url_request_job.h View 1 chunk +9 lines, -12 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 6 chunks +26 lines, -30 lines 2 comments Download
M android_webview/browser/net/aw_network_delegate.h View 1 chunk +26 lines, -29 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M android_webview/browser/net/aw_url_request_job_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:45:21 UTC) #1
boliu
https://codereview.chromium.org/896913002/diff/1/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc File android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc (right): https://codereview.chromium.org/896913002/diff/1/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc#newcode166 android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc:166: scoped_ptr<InputStreamReader> CreateStreamReader( this one was already missing override, so ...
5 years, 10 months ago (2015-02-04 01:04:38 UTC) #2
boliu
lgtm Err misread https://codereview.chromium.org/896913002/diff/1/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc File android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc (right): https://codereview.chromium.org/896913002/diff/1/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc#newcode166 android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc:166: scoped_ptr<InputStreamReader> CreateStreamReader( On 2015/02/04 01:04:38, boliu ...
5 years, 10 months ago (2015-02-04 01:06:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896913002/1
5 years, 10 months ago (2015-02-04 01:12:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 02:03:19 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:04:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7800168df87639c5f5fc758ce4159fee12600353
Cr-Commit-Position: refs/heads/master@{#314471}

Powered by Google App Engine
This is Rietveld 408576698