Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: android_webview/browser/net/android_stream_reader_url_request_job.h

Issue 896913002: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_NATIVE_ANDROID_STREAM_READER_URL_REQUEST_JOB_H_ 5 #ifndef ANDROID_WEBVIEW_NATIVE_ANDROID_STREAM_READER_URL_REQUEST_JOB_H_
6 #define ANDROID_WEBVIEW_NATIVE_ANDROID_STREAM_READER_URL_REQUEST_JOB_H_ 6 #define ANDROID_WEBVIEW_NATIVE_ANDROID_STREAM_READER_URL_REQUEST_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 virtual ~Delegate() {} 73 virtual ~Delegate() {}
74 }; 74 };
75 75
76 AndroidStreamReaderURLRequestJob( 76 AndroidStreamReaderURLRequestJob(
77 net::URLRequest* request, 77 net::URLRequest* request,
78 net::NetworkDelegate* network_delegate, 78 net::NetworkDelegate* network_delegate,
79 scoped_ptr<Delegate> delegate); 79 scoped_ptr<Delegate> delegate);
80 80
81 // URLRequestJob: 81 // URLRequestJob:
82 virtual void Start() override; 82 void Start() override;
83 virtual void Kill() override; 83 void Kill() override;
84 virtual bool ReadRawData(net::IOBuffer* buf, 84 bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;
85 int buf_size, 85 void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;
86 int* bytes_read) override; 86 bool GetMimeType(std::string* mime_type) const override;
87 virtual void SetExtraRequestHeaders( 87 bool GetCharset(std::string* charset) override;
88 const net::HttpRequestHeaders& headers) override; 88 int GetResponseCode() const override;
89 virtual bool GetMimeType(std::string* mime_type) const override; 89 void GetResponseInfo(net::HttpResponseInfo* info) override;
90 virtual bool GetCharset(std::string* charset) override;
91 virtual int GetResponseCode() const override;
92 virtual void GetResponseInfo(net::HttpResponseInfo* info) override;
93 90
94 protected: 91 protected:
95 virtual ~AndroidStreamReaderURLRequestJob(); 92 ~AndroidStreamReaderURLRequestJob() override;
96 93
97 // Gets the TaskRunner for the worker thread. 94 // Gets the TaskRunner for the worker thread.
98 // Overridden in unittests. 95 // Overridden in unittests.
99 virtual base::TaskRunner* GetWorkerThreadRunner(); 96 virtual base::TaskRunner* GetWorkerThreadRunner();
100 97
101 // Creates an InputStreamReader instance. 98 // Creates an InputStreamReader instance.
102 // Overridden in unittests to return a mock. 99 // Overridden in unittests to return a mock.
103 virtual scoped_ptr<android_webview::InputStreamReader> 100 virtual scoped_ptr<android_webview::InputStreamReader>
104 CreateStreamReader(android_webview::InputStream* stream); 101 CreateStreamReader(android_webview::InputStream* stream);
105 102
(...skipping 11 matching lines...) Expand all
117 scoped_ptr<Delegate> delegate_; 114 scoped_ptr<Delegate> delegate_;
118 scoped_refptr<InputStreamReaderWrapper> input_stream_reader_wrapper_; 115 scoped_refptr<InputStreamReaderWrapper> input_stream_reader_wrapper_;
119 base::ThreadChecker thread_checker_; 116 base::ThreadChecker thread_checker_;
120 117
121 base::WeakPtrFactory<AndroidStreamReaderURLRequestJob> weak_factory_; 118 base::WeakPtrFactory<AndroidStreamReaderURLRequestJob> weak_factory_;
122 119
123 DISALLOW_COPY_AND_ASSIGN(AndroidStreamReaderURLRequestJob); 120 DISALLOW_COPY_AND_ASSIGN(AndroidStreamReaderURLRequestJob);
124 }; 121 };
125 122
126 #endif // ANDROID_WEBVIEW_NATIVE_ANDROID_STREAM_READER_URL_REQUEST_JOB_H_ 123 #endif // ANDROID_WEBVIEW_NATIVE_ANDROID_STREAM_READER_URL_REQUEST_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698