Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 896903003: [PasswordManager clean-up] Merge copies of CreatePasswordFormFromData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@451018_more_scoped_vector
Patch Set: Rebased again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_store_default_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index 057fbfdb01b0b7a0d6f5d9c78ffd82a9a12ffb7c..3b06f4ab1b18cd6c8521ee2844052cf2a4245dc8 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -9,7 +9,7 @@
#include "base/strings/string_util.h"
#include "base/synchronization/waitable_event.h"
#include "base/time/time.h"
-#include "components/password_manager/core/browser/password_form_data.h"
+#include "components/password_manager/core/browser/password_manager_test_utils.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/browser/password_store_default.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -137,7 +137,8 @@ TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {
// Build the forms vector and add the forms to the store.
ScopedVector<PasswordForm> all_forms;
for (size_t i = 0; i < arraysize(form_data); ++i) {
- all_forms.push_back(CreatePasswordFormFromData(form_data[i]).release());
+ all_forms.push_back(
+ CreatePasswordFormFromDataForTesting(form_data[i]).release());
store->AddLogin(*all_forms.back());
}
base::MessageLoop::current()->RunUntilIdle();
« no previous file with comments | « components/password_manager/core/browser/password_store_default_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698