Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 896903003: [PasswordManager clean-up] Merge copies of CreatePasswordFormFromData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@451018_more_scoped_vector
Patch Set: Rebased again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_default_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc
index fe9a6fbd2c7beea8c45e3276a913ba4a2fb16a34..73ff7e7116c4e735a63def0822454f8ddbcd831c 100644
--- a/components/password_manager/core/browser/password_store_default_unittest.cc
+++ b/components/password_manager/core/browser/password_store_default_unittest.cc
@@ -13,7 +13,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "components/password_manager/core/browser/login_database.h"
-#include "components/password_manager/core/browser/password_form_data.h"
+#include "components/password_manager/core/browser/password_manager_test_utils.h"
#include "components/password_manager/core/browser/password_store_change.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/browser/password_store_default.h"
@@ -121,7 +121,7 @@ TEST_F(PasswordStoreDefaultTest, NonASCIIData) {
ScopedVector<PasswordForm> expected_forms;
for (unsigned int i = 0; i < arraysize(form_data); ++i) {
expected_forms.push_back(
- CreatePasswordFormFromData(form_data[i]).release());
+ CreatePasswordFormFromDataForTesting(form_data[i]).release());
store->AddLogin(*expected_forms.back());
}
@@ -147,7 +147,7 @@ TEST_F(PasswordStoreDefaultTest, Notifications) {
store->Init(syncer::SyncableService::StartSyncFlare());
scoped_ptr<PasswordForm> form =
- CreatePasswordFormFromData(CreateTestPasswordFormData());
+ CreatePasswordFormFromDataForTesting(CreateTestPasswordFormData());
MockPasswordStoreObserver observer;
store->AddObserver(&observer);
@@ -210,7 +210,7 @@ TEST_F(PasswordStoreDefaultTest, OperationsOnABadDatabaseSilentlyFail) {
// Add a new autofillable login + a blacklisted login.
scoped_ptr<PasswordForm> form =
- CreatePasswordFormFromData(CreateTestPasswordFormData());
+ CreatePasswordFormFromDataForTesting(CreateTestPasswordFormData());
scoped_ptr<PasswordForm> blacklisted_form(new PasswordForm(*form));
blacklisted_form->signon_realm = "http://foo.example.com";
blacklisted_form->origin = GURL("http://foo.example.com/origin");

Powered by Google App Engine
This is Rietveld 408576698