chrome/browser/password_manager/password_store_x_unittest.cc - Issue 896903003: [PasswordManager clean-up] Merge copies of CreatePasswordFormFromData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x_unittest.cc

Issue 896903003: [PasswordManager clean-up] Merge copies of CreatePasswordFormFromData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@451018_more_scoped_vector

Patch Set: Rebased again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_win_unittest.cc ('k') | chrome/browser/sync/test/integration/multiple_client_passwords_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_x_unittest.cc b/chrome/browser/password_manager/password_store_x_unittest.cc

index 60b1581d003a0abab5fd0417d19bcd72a1d5af36..35ab9bc0d0ac015f0b37a444caffda39ed7a42c6 100644

--- a/chrome/browser/password_manager/password_store_x_unittest.cc

+++ b/chrome/browser/password_manager/password_store_x_unittest.cc

@@ -16,7 +16,7 @@

#include "base/time/time.h"

#include "chrome/browser/password_manager/password_store_x.h"

#include "chrome/test/base/testing_browser_process.h"

-#include "components/password_manager/core/browser/password_form_data.h"

+#include "components/password_manager/core/browser/password_manager_test_utils.h"

#include "components/password_manager/core/browser/password_store_change.h"

#include "components/password_manager/core/browser/password_store_consumer.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

@@ -237,7 +237,7 @@ void InitExpectedForms(bool autofillable,

autofillable,

false,

static_cast<double>(i + 1)};

- forms->push_back(CreatePasswordFormFromData(data).release());

+ forms->push_back(CreatePasswordFormFromDataForTesting(data).release());

}

@@ -296,7 +296,8 @@ TEST_P(PasswordStoreXTest, Notifications) {

L"password_element", L"username_value",

L"password_value", true,

false, 1};

- scoped_ptr<PasswordForm> form = CreatePasswordFormFromData(form_data);

+ scoped_ptr<PasswordForm> form =

+ CreatePasswordFormFromDataForTesting(form_data);

MockPasswordStoreObserver observer;

store->AddObserver(&observer);