Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/browser/password_manager/password_store_win_unittest.cc

Issue 896903003: [PasswordManager clean-up] Merge copies of CreatePasswordFormFromData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@451018_more_scoped_vector
Patch Set: Rebased again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_win_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_win_unittest.cc b/chrome/browser/password_manager/password_store_win_unittest.cc
index b81b9becf92e17d863d4fad25753c7053a6f68a8..df5869b0c8402540326ce2a76167835181372727 100644
--- a/chrome/browser/password_manager/password_store_win_unittest.cc
+++ b/chrome/browser/password_manager/password_store_win_unittest.cc
@@ -19,7 +19,7 @@
#include "chrome/browser/password_manager/password_store_win.h"
#include "chrome/test/base/testing_profile.h"
#include "components/os_crypt/ie7_password_win.h"
-#include "components/password_manager/core/browser/password_form_data.h"
+#include "components/password_manager/core/browser/password_manager_test_utils.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/browser/webdata/logins_table.h"
#include "components/password_manager/core/browser/webdata/password_web_data_service_win.h"
@@ -230,7 +230,8 @@ TEST_F(PasswordStoreWinTest, DISABLED_ConvertIE7Login) {
L"",
true, false, 1,
};
- scoped_ptr<PasswordForm> form = CreatePasswordFormFromData(form_data);
+ scoped_ptr<PasswordForm> form =
+ CreatePasswordFormFromDataForTesting(form_data);
// The returned form will not have 'action' or '*_element' fields set. This
// is because credentials imported from IE don't have this information.
@@ -247,7 +248,8 @@ TEST_F(PasswordStoreWinTest, DISABLED_ConvertIE7Login) {
true, false, 1,
};
ScopedVector<autofill::PasswordForm> expected_forms;
- expected_forms.push_back(CreatePasswordFormFromData(expected_form_data));
+ expected_forms.push_back(
+ CreatePasswordFormFromDataForTesting(expected_form_data));
// The IE7 password should be returned.
EXPECT_CALL(consumer, OnGetPasswordStoreResultsConstRef(
@@ -274,7 +276,8 @@ TEST_F(PasswordStoreWinTest, DISABLED_OutstandingWDSQueries) {
L"",
true, false, 1,
};
- scoped_ptr<PasswordForm> form = CreatePasswordFormFromData(form_data);
+ scoped_ptr<PasswordForm> form =
+ CreatePasswordFormFromDataForTesting(form_data);
MockPasswordStoreConsumer consumer;
store_->GetLogins(*form, PasswordStore::DISALLOW_PROMPT, &consumer);
@@ -322,7 +325,8 @@ TEST_F(PasswordStoreWinTest, DISABLED_MultipleWDSQueriesOnDifferentThreads) {
L"",
true, false, 1,
};
- scoped_ptr<PasswordForm> form = CreatePasswordFormFromData(form_data);
+ scoped_ptr<PasswordForm> form =
+ CreatePasswordFormFromDataForTesting(form_data);
PasswordFormData expected_form_data = {
PasswordForm::SCHEME_HTML,
@@ -337,7 +341,8 @@ TEST_F(PasswordStoreWinTest, DISABLED_MultipleWDSQueriesOnDifferentThreads) {
true, false, 1,
};
ScopedVector<autofill::PasswordForm> expected_forms;
- expected_forms.push_back(CreatePasswordFormFromData(expected_form_data));
+ expected_forms.push_back(
+ CreatePasswordFormFromDataForTesting(expected_form_data));
// The IE7 password should be returned.
EXPECT_CALL(password_consumer,
@@ -376,7 +381,8 @@ TEST_F(PasswordStoreWinTest, EmptyLogins) {
L"",
true, false, 1,
};
- scoped_ptr<PasswordForm> form = CreatePasswordFormFromData(form_data);
+ scoped_ptr<PasswordForm> form =
+ CreatePasswordFormFromDataForTesting(form_data);
MockPasswordStoreConsumer consumer;

Powered by Google App Engine
This is Rietveld 408576698