Source/core/css/parser/CSSPropertyParser.cpp - Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: circling back towards patchset #1 again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index 539ad6ed8b536633969c16a67cce948d565f22a6..2d4d66f732bca1606297a8ef2d73b7f557006e61 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -8197,6 +8197,10 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)

if (id == CSSValueLuminance || id == CSSValueAlpha)

validPrimitive = true;

break;

+ case CSSPropertyX:

+ case CSSPropertyY:

+ validPrimitive = (!id && validUnit(value, FLength | FPercent, SVGAttributeMode));

+ break;

/* shorthand properties */

case CSSPropertyMarker: {