Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 896773002: [svg2] Make 'x' and 'y' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: circling back towards patchset #1 again Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 8179 matching lines...) Expand 10 before | Expand all | Expand 10 after
8190 if (id == CSSValueNone) 8190 if (id == CSSValueNone)
8191 validPrimitive = true; 8191 validPrimitive = true;
8192 else 8192 else
8193 parsedValue = parseSVGStrokeDasharray(); 8193 parsedValue = parseSVGStrokeDasharray();
8194 break; 8194 break;
8195 8195
8196 case CSSPropertyMaskType: // luminance | alpha | inherit 8196 case CSSPropertyMaskType: // luminance | alpha | inherit
8197 if (id == CSSValueLuminance || id == CSSValueAlpha) 8197 if (id == CSSValueLuminance || id == CSSValueAlpha)
8198 validPrimitive = true; 8198 validPrimitive = true;
8199 break; 8199 break;
8200 case CSSPropertyX:
8201 case CSSPropertyY:
8202 validPrimitive = (!id && validUnit(value, FLength | FPercent, SVGAttribu teMode));
8203 break;
8200 8204
8201 /* shorthand properties */ 8205 /* shorthand properties */
8202 case CSSPropertyMarker: { 8206 case CSSPropertyMarker: {
8203 ShorthandScope scope(this, propId); 8207 ShorthandScope scope(this, propId);
8204 CSSPropertyParser::ImplicitScope implicitScope(this); 8208 CSSPropertyParser::ImplicitScope implicitScope(this);
8205 if (!parseValue(CSSPropertyMarkerStart, important)) 8209 if (!parseValue(CSSPropertyMarkerStart, important))
8206 return false; 8210 return false;
8207 if (m_valueList->current()) { 8211 if (m_valueList->current()) {
8208 rollbackLastProperties(1); 8212 rollbackLastProperties(1);
8209 return false; 8213 return false;
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
8578 } 8582 }
8579 } 8583 }
8580 8584
8581 if (!list->length()) 8585 if (!list->length())
8582 return nullptr; 8586 return nullptr;
8583 8587
8584 return list.release(); 8588 return list.release();
8585 } 8589 }
8586 8590
8587 } // namespace blink 8591 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698