Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

Issue 896763003: dart2js: emit noSuchMethod stubs in the new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
index 37241459e02d190e9ca1fc1f404f0d3fbd833fe5..74d3ee0d0714a17f815a39f7fddd9a4cb1239825 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart
@@ -49,11 +49,9 @@ class NsmEmitter extends CodeEmitterHelper {
isTrivialNsmHandler(type, argNames, selector, jsName) &&
reflectionName == null) {
trivialNsmHandlers.add(selector);
- }
-
- jsAst.Expression method = generator.generateStubForNoSuchMethod(selector);
- if (method != null) {
- addProperty(jsName, method);
+ } else {
+ StubMethod method = generator.generateStubForNoSuchMethod(selector);
+ addProperty(jsName, method.code);
floitsch 2015/02/03 13:07:08 addProperty(method.name, method.code) ? assert tha
zarah 2015/02/03 14:07:10 Passing it to the generator now.
if (reflectionName != null) {
bool accessible = compiler.world.allFunctions.filter(selector).any(
(Element e) => backend.isAccessibleByReflection(e));
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698