dart2js: emit noSuchMethod stubs in the new emitter.

pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.js_emitter;
 
 class NsmEmitter extends CodeEmitterHelper {
   final List<Selector> trivialNsmHandlers = <Selector>[];
 
   /// If this is true then we can generate the noSuchMethod handlers at startup
@@ skipping 31 matching lines @@
       }
 
       List<jsAst.Expression> argNames =
                selector.getOrderedNamedArguments().map((String name) =>
                    js.string(name)).toList();
       int type = selector.invocationMirrorKind;
       if (!haveVeryFewNoSuchMemberHandlers &&
           isTrivialNsmHandler(type, argNames, selector, jsName) &&
           reflectionName == null) {
         trivialNsmHandlers.add(selector);
-      }
-
-      jsAst.Expression method = generator.generateStubForNoSuchMethod(selector);
-      if (method != null) {
-        addProperty(jsName, method);
+      } else {
+        StubMethod method = generator.generateStubForNoSuchMethod(selector);
+        addProperty(jsName, method.code);

[floitsch, 2015/02/03 13:07:08]

addProperty(method.name, method.code) ?
assert that they are the same?

[zarah, 2015/02/03 14:07:10]

Passing it to the generator now.

         if (reflectionName != null) {
           bool accessible = compiler.world.allFunctions.filter(selector).any(
               (Element e) => backend.isAccessibleByReflection(e));
           addProperty('+$reflectionName', js(accessible ? '2' : '0'));
         }
       }
     }
   }
 
   // Identify the noSuchMethod handlers that are so simple that we can
@@ skipping 257 matching lines @@
       }''', {
           'sliceOffsetParams': sliceOffsetParams,
           'noSuchMethodName': namer.noSuchMethodName,
           'createInvocationMirror': createInvocationMirror,
           'names': minify ? 'shortNames' : 'longNames',
           'sliceOffsetArguments': sliceOffsetArguments}));
 
     return statements;
   }
 }