Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 896673005: Add a test to make sure source port cannot be transferred. (Closed)

Created:
5 years, 10 months ago by sgurun-gerrit only
Modified:
5 years, 10 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test to make sure source port cannot be transferred. BUG=393291 Committed: https://crrev.com/a5232de72e5c5e7f12c6f5e68440283d33d4d0f1 Cr-Commit-Position: refs/heads/master@{#314604}

Patch Set 1 #

Patch Set 2 : minor stylistic fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/MessagePort.java View 1 1 chunk +5 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java View 2 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sgurun-gerrit only
On 2015/02/04 18:16:26, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:hush@chromium.org ptal
5 years, 10 months ago (2015-02-04 18:17:18 UTC) #2
hush (inactive)
lgtm
5 years, 10 months ago (2015-02-04 18:22:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896673005/20001
5 years, 10 months ago (2015-02-04 18:24:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 19:12:53 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 19:14:07 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5232de72e5c5e7f12c6f5e68440283d33d4d0f1
Cr-Commit-Position: refs/heads/master@{#314604}

Powered by Google App Engine
This is Rietveld 408576698