Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2161)

Unified Diff: android_webview/java/src/org/chromium/android_webview/MessagePort.java

Issue 896673005: Add a test to make sure source port cannot be transferred. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor stylistic fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/MessagePort.java
diff --git a/android_webview/java/src/org/chromium/android_webview/MessagePort.java b/android_webview/java/src/org/chromium/android_webview/MessagePort.java
index e04035553a03630ff80d886558c469fc9101b7b1..4025c4507264c56d4fd753c4bd53be8e57955ece 100644
--- a/android_webview/java/src/org/chromium/android_webview/MessagePort.java
+++ b/android_webview/java/src/org/chromium/android_webview/MessagePort.java
@@ -70,7 +70,11 @@ public class MessagePort {
if (msgPorts != null) {
portIds = new int[msgPorts.length];
for (int i = 0; i < msgPorts.length; i++) {
- portIds[i] = msgPorts[i].portId();
+ int sentId = msgPorts[i].portId();
+ if (sentId == mPortId) {
+ throw new IllegalStateException("Source port cannot be transferred");
+ }
+ portIds[i] = sentId;
}
}
mMessagePortService.postMessage(mPortId, message, portIds);
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698