Propagate audible state from player to the containing tab

media/base/android/media_player_bridge.h

Index: media/base/android/media_player_bridge.h
diff --git a/media/base/android/media_player_bridge.h b/media/base/android/media_player_bridge.h
index 9dd6eecfa4dad59dc4ca17c59082a91a15092c6a..69f894dcfa4a794a2808fe1d1d0c38e1787b75a9 100644
--- a/media/base/android/media_player_bridge.h
+++ b/media/base/android/media_player_bridge.h
@@ -175,8 +175,11 @@ class MEDIA_EXPORT MediaPlayerBridge : public MediaPlayerAndroid {
 
   base::RepeatingTimer<MediaPlayerBridge> time_update_timer_;
 
-  // Volume of playback.
-  double volume_;
+  // Initial playback volume
+  double initial_volume_;

[qinmin, 2015/02/04 03:27:54]

why we need 2 volumes? I think java and native should see the same volume, if
java object is not created, we can check j_media_player_bridge_.obj()

[Tima Vaisburd, 2015/02/04 17:39:01]

I noticed that original code did not maintain the |volume_| if
j_media_player_bridge_ exists
(https://cs.corp.google.com/#clankium/src/media/base/android/media_player_brid...).
Is this on purpose?

[qinmin, 2015/02/04 19:16:16]

That looks like a bug to me. Although the first setVolume() is called before
MediaPlayer gets constructed, we might still lose the volume if another
setVolume() is called while the player is playing and then it gets released.
MediaSourcePlayer has the correct implementation.

[Tima Vaisburd, 2015/02/05 23:22:27]

Simplified SetVolume() the same way AudioDecoderJob works.

+
+  // Current playback volume that has been passed to Java
+  double current_volume_;
 
   // Whether user credentials are allowed to be passed.
   bool allow_credentials_;