Propagate audible state from player to the containing tab

media/base/android/media_player_bridge.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_ANDROID_MEDIA_PLAYER_BRIDGE_H_
 #define MEDIA_BASE_ANDROID_MEDIA_PLAYER_BRIDGE_H_
 
 #include <jni.h>
 #include <map>
 #include <string>
@@ skipping 157 matching lines @@
   bool can_seek_backward_;
 
   // Cookies for |url_|.
   std::string cookies_;
 
   // Java MediaPlayerBridge instance.
   base::android::ScopedJavaGlobalRef<jobject> j_media_player_bridge_;
 
   base::RepeatingTimer<MediaPlayerBridge> time_update_timer_;
 
-  // Volume of playback.
-  double volume_;
+  // Initial playback volume
+  double initial_volume_;

[qinmin, 2015/02/04 03:27:54]

why we need 2 volumes? I think java and native should see the same volume, if
java object is not created, we can check j_media_player_bridge_.obj()

[Tima Vaisburd, 2015/02/04 17:39:01]

I noticed that original code did not maintain the |volume_| if
j_media_player_bridge_ exists
(https://cs.corp.google.com/#clankium/src/media/base/android/media_player_brid...).
Is this on purpose?

[qinmin, 2015/02/04 19:16:16]

That looks like a bug to me. Although the first setVolume() is called before
MediaPlayer gets constructed, we might still lose the volume if another
setVolume() is called while the player is playing and then it gets released.
MediaSourcePlayer has the correct implementation.

[Tima Vaisburd, 2015/02/05 23:22:27]

Simplified SetVolume() the same way AudioDecoderJob works.

+
+  // Current playback volume that has been passed to Java
+  double current_volume_;
 
   // Whether user credentials are allowed to be passed.
   bool allow_credentials_;
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<MediaPlayerBridge> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaPlayerBridge);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_ANDROID_MEDIA_PLAYER_BRIDGE_H_