content/browser/web_contents/web_contents_impl.cc - Issue 896673003: Propagate audible state from player to the containing tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 896673003: Propagate audible state from player to the containing tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Ted's comments and compiled IsAudible() only under OS_ANDROID Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/media_web_contents_observer.h ('K') | « content/browser/media/media_web_contents_observer.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index d32b7cc1dc744a1ad9674bfca7a2f5db2bf6f8e0..3b287ace42520fab72df9231b3d6e342dba278b8 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2493,7 +2493,11 @@ void WebContentsImpl::InsertCSS(const std::string& css) {

}

bool WebContentsImpl::WasRecentlyAudible() {

+#if defined(ENABLE_BROWSER_CDMS) && defined(OS_ANDROID)

no sievers 2015/02/10 01:33:03 Why is there an #ifdef here? Can you put a comment

Tima Vaisburd 2015/02/11 03:34:05 Added a comment, please take a look.

+ return media_web_contents_observer_->IsAudible();

+#else

return audio_stream_monitor_.WasRecentlyAudible();

+#endif

}

void WebContentsImpl::GetManifest(const GetManifestCallback& callback) {

« content/browser/media/media_web_contents_observer.h ('K') | « content/browser/media/media_web_contents_observer.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »