Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: content/browser/media/media_web_contents_observer.cc

Issue 896673003: Propagate audible state from player to the containing tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ted's comments and compiled IsAudible() only under OS_ANDROID Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/media_web_contents_observer.cc
diff --git a/content/browser/media/media_web_contents_observer.cc b/content/browser/media/media_web_contents_observer.cc
index cc90b55ec02b7c582ccf883eb5c942b345369683..6c0a87b9117b15a1ac5538a831128e22809bbc74 100644
--- a/content/browser/media/media_web_contents_observer.cc
+++ b/content/browser/media/media_web_contents_observer.cc
@@ -13,6 +13,7 @@
#include "ipc/ipc_message_macros.h"
#if defined(OS_ANDROID)
+#include "content/browser/android/audio_monitor_android.h"
#include "content/browser/media/android/browser_media_player_manager.h"
#include "content/common/media/media_player_messages_android.h"
#include "media/base/android/media_player_android.h"
@@ -22,7 +23,11 @@ namespace content {
MediaWebContentsObserver::MediaWebContentsObserver(
WebContents* web_contents)
- : WebContentsObserver(web_contents) {
+ : WebContentsObserver(web_contents)
+#if defined (OS_ANDROID)
+ , audio_monitor_(new AudioMonitorAndroid(web_contents))
+#endif // defined (OS_ANDROID)
+{
}
MediaWebContentsObserver::~MediaWebContentsObserver() {
@@ -35,6 +40,7 @@ void MediaWebContentsObserver::RenderFrameDeleted(
// Always destroy the media players before CDMs because we do not support
// detaching CDMs from media players yet. See http://crbug.com/330324
media_player_managers_.erase(key);
+ audio_monitor_->RenderFrameDeleted(render_frame_host);
#endif
// TODO(xhwang): Currently MediaWebContentsObserver, BrowserMediaPlayerManager
// and BrowserCdmManager all run on browser UI thread. So this call is okay.
@@ -47,8 +53,13 @@ void MediaWebContentsObserver::RenderFrameDeleted(
browser_cdm_manager->RenderFrameDeleted(render_frame_host->GetRoutingID());
}
+
#if defined(OS_ANDROID)
+bool MediaWebContentsObserver::IsAudible() const {
+ return audio_monitor_->is_audible();
+}
+
bool MediaWebContentsObserver::OnMessageReceived(
const IPC::Message& msg,
RenderFrameHost* render_frame_host) {
@@ -161,7 +172,8 @@ BrowserMediaPlayerManager* MediaWebContentsObserver::GetMediaPlayerManager(
if (!media_player_managers_.contains(key)) {
media_player_managers_.set(
key,
- make_scoped_ptr(BrowserMediaPlayerManager::Create(render_frame_host)));
+ make_scoped_ptr(BrowserMediaPlayerManager::Create(
+ render_frame_host, audio_monitor_.get())));
}
return media_player_managers_.get(key);
}

Powered by Google App Engine
This is Rietveld 408576698