win: Resolve zero-length array errors on MSVC

minidump/minidump_extensions.h

Index: minidump/minidump_extensions.h
diff --git a/minidump/minidump_extensions.h b/minidump/minidump_extensions.h
index 2ec3403ad68794942b0943729016071e50ce7312..e73447314a1f49e77575530e1651658b304dbb3d 100644
--- a/minidump/minidump_extensions.h
+++ b/minidump/minidump_extensions.h
@@ -25,6 +25,15 @@
 #include "util/misc/uuid.h"
 
 #if defined(COMPILER_MSVC)
+// C4200 is "nonstandard extension used : zero-sized array in struct/union".
+// We would like to globally disable this warning, but unfortunately, the
+// compiler is buggy and only supports disabling it with a pragma, so we can't
+// disable it with other silly warnings in build/common.gypi. See:
+//   https://connect.microsoft.com/VisualStudio/feedback/details/1114440
+#pragma warning(disable: 4200)

[Mark Mentovai, 2015/02/04 21:25:15]

Can we undisable it at the end of this header and still get the desired effect?
I’d rather do that if possible, so that each header that needs this #pragma is
forced to provide it on its own, rather than relying on #include order quirks.

[scottmg, 2015/02/05 01:33:26]

Done.

+#endif  // COMPILER_MSVC
+
+#if defined(COMPILER_MSVC)
 #define PACKED
 #pragma pack(push, 1)
 #else