Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 896653007: "Chromium Autofill Settings" option should open autofill settings page. (Closed)

Created:
5 years, 10 months ago by divya.bansal
Modified:
5 years, 10 months ago
Reviewers:
newt (away), Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

"Chromium Autofill Settings" option should open autofill settings page. Added code to open autofill settings page. If "Chromium Autofill Settings" option" is selected from autofill menu autofill forms settings page should be opened. Please enter the commit message for your changes. Lines starting BUG=454779 Committed: https://crrev.com/0e3bcf1aa58bbe05fa04767b56a64486792e5b3b Cr-Commit-Position: refs/heads/master@{#314716}

Patch Set 1 #

Patch Set 2 : Review changes #

Patch Set 3 : review changes #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java View 1 2 3 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
divya.bansal
@newt, @Evan PTAL
5 years, 10 months ago (2015-02-03 13:06:05 UTC) #2
newt (away)
Actually, could you please change ChromiumApplication instead of ChromeShellApplication? Here's what the code should be ...
5 years, 10 months ago (2015-02-03 15:58:40 UTC) #3
divya.bansal
@newt Thanks for the review. PTAL
5 years, 10 months ago (2015-02-04 03:54:26 UTC) #4
newt (away)
lgtm
5 years, 10 months ago (2015-02-04 19:36:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896653007/60001
5 years, 10 months ago (2015-02-05 01:27:28 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-05 01:54:03 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 01:56:22 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0e3bcf1aa58bbe05fa04767b56a64486792e5b3b
Cr-Commit-Position: refs/heads/master@{#314716}

Powered by Google App Engine
This is Rietveld 408576698