Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2922)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java

Issue 896653007: "Chromium Autofill Settings" option should open autofill settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
index 8e0ddec968ac9e0ece6c9ce3149e0b6347adc1c7..646cc59e8c02d9b7c8cde8662fca395f0d4c4d03 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
@@ -4,8 +4,14 @@
package org.chromium.chrome.browser;
+import android.os.Build;
+
import org.chromium.base.CalledByNative;
import org.chromium.chrome.browser.preferences.LocationSettings;
+import org.chromium.chrome.browser.preferences.PreferencesLauncher;
+import org.chromium.chrome.browser.preferences.ProtectedContentPreferences;
+import org.chromium.chrome.browser.preferences.autofill.AutofillPreferences;
+import org.chromium.chrome.browser.preferences.password.ManageSavedPasswordsPreferences;
import org.chromium.content.app.ContentApplication;
/**
@@ -23,13 +29,23 @@ public abstract class ChromiumApplication extends ContentApplication {
* Opens a protected content settings page, if available.
*/
@CalledByNative
- protected void openProtectedContentSettings() {}
+ protected void openProtectedContentSettings() {
+ assert Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT;
+ PreferencesLauncher.launchSettingsPage(this,
+ ProtectedContentPreferences.class.getName());
+ }
@CalledByNative
- protected void showAutofillSettings() {}
+ protected void showAutofillSettings() {
+ PreferencesLauncher.launchSettingsPage(this,
+ AutofillPreferences.class.getName());
+ }
@CalledByNative
- protected void showPasswordSettings() {}
+ protected void showPasswordSettings() {
+ PreferencesLauncher.launchSettingsPage(this,
+ ManageSavedPasswordsPreferences.class.getName());
+ }
/**
* Returns an instance of LocationSettings to be installed as a singleton.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698