Issue 896523004: Revert "Revert of Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach…

Issue 896523004: Revert "Revert of Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach… (Closed)

Created:
5 years, 10 months ago by sof

Modified:
5 years, 10 months ago

Reviewers:
haraken, Noel Gordon

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert "Revert of Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach. (patchset #1 id:1 of https://codereview.chromium.org/896103002/)" This reverts commit b66d223c1aca5ca01eb08d93dc1f5687584cd147. This CL is suspect wrt the ChromeOS test failure as outlined in https://codereview.chromium.org/890243003/#msg6 reverting to ensure that that issue is taken care of; see https://code.google.com/p/chromium/issues/detail?id=455161 TBR=noel@chromium.org BUG=446452 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189478

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -22 lines)			Patch
M	LayoutTests/OilpanExpectations	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt	View	3 chunks	+17 lines, -17 lines	0 comments	Download
M	Source/core/frame/FrameDestructionObserver.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/frame/FrameDestructionObserver.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/LocalFrame.cpp	View	2 chunks	+8 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896523004/1

5 years, 10 months ago (2015-02-04 10:50:45 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189478

5 years, 10 months ago (2015-02-04 10:51:51 UTC) #6

Message was sent while issue was closed.

LGTM