Source/core/frame/FrameDestructionObserver.h - Issue 896523004: Revert "Revert of Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameDestructionObserver.h

Issue 896523004: Revert "Revert of Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt ('k') | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameDestructionObserver.h

diff --git a/Source/core/frame/FrameDestructionObserver.h b/Source/core/frame/FrameDestructionObserver.h

index b4dd3d997d78ad67af154485addaa9cc3b0d17dd..a62d20210447fe2a5986198e606afdd637e4bbd7 100644

--- a/Source/core/frame/FrameDestructionObserver.h

+++ b/Source/core/frame/FrameDestructionObserver.h

@@ -36,7 +36,15 @@ class FrameDestructionObserver : public WillBeGarbageCollectedMixin {

public:

explicit FrameDestructionObserver(LocalFrame*);

+#if !ENABLE(OILPAN)

+ // Oilpan: there is no known need for directly observing

+ // frameDestroyed() with Oilpan enabled, as its clearing is

+ // handled by keeping a weak reference.

+ //

+ // A weak callback version of frameDestroyed() can be reintroduced

+ // later, should the need arise.

virtual void frameDestroyed();

+#endif

virtual void willDetachFrameHost();

LocalFrame* frame() const { return m_frame; }