Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 896463002: Remove the WEBCORE_NAVIGATOR_* defines (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the WEBCORE_NAVIGATOR_* defines This is motivated by navigator.vendor, which Opera and multiple other Chromium-based browsers have tweaked using this mechanism instead of treating it like the long-frozen navigator.appName "Netscape". There are cases of site compat issues caused by this, in a library called UDM: http://www.udm4.com/demos/horizontal-relative-left.php The "Intent to Implement and Ship: navigator.vendor as the empty string" did not get the support required to align with Firefox and IE, so freezing it in time as "Google Inc." is the second best thing. It's unlikely that any of the other defines have been used. History and discussion: https://code.google.com/p/chromium/issues/detail?id=276813 https://www.w3.org/Bugs/Public/show_bug.cgi?id=27786 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QrgyulnqvmE BUG=276813, 454291 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -24 lines) Patch
M Source/core/frame/Navigator.cpp View 2 chunks +7 lines, -15 lines 0 comments Download
M Source/core/frame/NavigatorID.cpp View 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 10 months ago (2015-02-02 15:24:06 UTC) #2
pdr.
On 2015/02/02 at 15:24:06, philipj wrote: > PTAL LGTM! Thank you for sticking through this.
5 years, 10 months ago (2015-02-03 18:58:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896463002/1
5 years, 10 months ago (2015-02-03 19:38:51 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:52:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189436

Powered by Google App Engine
This is Rietveld 408576698