Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: Source/core/frame/Navigator.cpp

Issue 896463002: Remove the WEBCORE_NAVIGATOR_* defines (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/NavigatorID.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Navigator.cpp
diff --git a/Source/core/frame/Navigator.cpp b/Source/core/frame/Navigator.cpp
index 31566887ea8c31ba39f7f95fdab2b32238738c1e..0460218c2a34d25516a9e751cd54d1028b244445 100644
--- a/Source/core/frame/Navigator.cpp
+++ b/Source/core/frame/Navigator.cpp
@@ -37,18 +37,6 @@
#include "core/plugins/DOMPluginArray.h"
#include "platform/Language.h"
-#ifndef WEBCORE_NAVIGATOR_PRODUCT_SUB
-#define WEBCORE_NAVIGATOR_PRODUCT_SUB "20030107"
-#endif // ifndef WEBCORE_NAVIGATOR_PRODUCT_SUB
-
-#ifndef WEBCORE_NAVIGATOR_VENDOR
-#define WEBCORE_NAVIGATOR_VENDOR "Google Inc."
-#endif // ifndef WEBCORE_NAVIGATOR_VENDOR
-
-#ifndef WEBCORE_NAVIGATOR_VENDOR_SUB
-#define WEBCORE_NAVIGATOR_VENDOR_SUB ""
-#endif // ifndef WEBCORE_NAVIGATOR_VENDOR_SUB
-
namespace blink {
Navigator::Navigator(LocalFrame* frame)
@@ -62,17 +50,21 @@ Navigator::~Navigator()
String Navigator::productSub() const
{
- return WEBCORE_NAVIGATOR_PRODUCT_SUB;
+ return "20030107";
}
String Navigator::vendor() const
{
- return WEBCORE_NAVIGATOR_VENDOR;
+ // Do not change without good cause. History:
+ // https://code.google.com/p/chromium/issues/detail?id=276813
+ // https://www.w3.org/Bugs/Public/show_bug.cgi?id=27786
+ // https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QrgyulnqvmE
+ return "Google Inc.";
}
String Navigator::vendorSub() const
{
- return WEBCORE_NAVIGATOR_VENDOR_SUB;
+ return "";
}
String Navigator::userAgent() const
« no previous file with comments | « no previous file | Source/core/frame/NavigatorID.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698