Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 896423003: cc: Fix multiple outstanding output surface requests (Closed)

Created:
5 years, 10 months ago by enne (OOO)
Modified:
5 years, 10 months ago
Reviewers:
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2272
Target Ref:
refs/pending/branch-heads/2272
Project:
chromium
Visibility:
Public.

Description

cc: Fix multiple outstanding output surface requests SingleThreadProxy was previously not considering DidFailToInitializeOutputSurface responses as an outstanding RequestNewOutputSurface call. This would cause the embedder to start servicing an output surface request, then composite, receive another, and then have double output surface requests. The fix is to consider this failure state as a request. TBR=danakj@chromium.org,jbauman@chromium.org,sievers@chromium.org BUG=444277 Review URL: https://codereview.chromium.org/871743002 Cr-Commit-Position: refs/heads/master@{#313357} (cherry picked from commit 5232fbbf8df7e06471950a12bc041c766e31a997) Committed: https://chromium.googlesource.com/chromium/src/+/647161e2a8fa4dfdaac0c1f1b263e70bf8d483f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -22 lines) Patch
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +25 lines, -9 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor_unittest.cc View 4 chunks +28 lines, -9 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/test/fake_compositor_dependencies.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
enne (OOO)
5 years, 10 months ago (2015-02-05 19:03:12 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
647161e2a8fa4dfdaac0c1f1b263e70bf8d483f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698