cc: Fix multiple outstanding output surface requests

cc: Fix multiple outstanding output surface requests

SingleThreadProxy was previously not considering
DidFailToInitializeOutputSurface responses as an outstanding
RequestNewOutputSurface call. This would cause the embedder to start
servicing an output surface request, then composite, receive another,
and then have double output surface requests.

The fix is to consider this failure state as a request.

BUG=444277
Committed: https://crrev.com/5232fbbf8df7e06471950a12bc041c766e31a997
Cr-Commit-Position: refs/heads/master@{#313357}

[enne (OOO), 2015-01-22 22:56:21]

enne@chromium.org changed reviewers:
+ danakj@chromium.org, jbauman@chromium.org

[enne (OOO), 2015-01-22 22:56:28]

Sorry for the belated fix here.  :(

[danakj, 2015-01-22 23:01:27]

LGTM

[enne (OOO), 2015-01-22 23:11:23]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-01-22 23:13:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/871743002/1

[commit-bot: I haz the power, 2015-01-23 00:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 00:42:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2015-01-23 01:13:12]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-01-23 01:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/871743002/1

[commit-bot: I haz the power, 2015-01-23 01:17:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 01:17:01]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[enne (OOO), 2015-01-27 01:41:20]

Fixed content_unittests.

jbauman: content/renderer/gpu OWNERS (I added a function to muck with cc
settings to avoid command line injection)
danakj: look over the unit test changes

[danakj, 2015-01-27 01:46:37]

LGTM but..

https://codereview.chromium.org/871743002/diff/20001/content/renderer/gpu/ren...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/871743002/diff/20001/content/renderer/gpu/ren...
content/renderer/gpu/render_widget_compositor.cc:444: }
Add a comment here somewhere this if for tests?

https://codereview.chromium.org/871743002/diff/20001/content/renderer/gpu/ren...
File content/renderer/gpu/render_widget_compositor_unittest.cc (right):

https://codereview.chromium.org/871743002/diff/20001/content/renderer/gpu/ren...
content/renderer/gpu/render_widget_compositor_unittest.cc:132:
settings->single_thread_proxy_scheduler = false;
You could add a function to CompositorDependencies and have this test's
FakeCompositorDependencies return the right value? That'd build on what we have
instead of making another way for tests to change things.

[enne (OOO), 2015-01-27 01:59:43]

https://codereview.chromium.org/871743002/diff/20001/content/renderer/gpu/ren...
File content/renderer/gpu/render_widget_compositor_unittest.cc (right):

https://codereview.chromium.org/871743002/diff/20001/content/renderer/gpu/ren...
content/renderer/gpu/render_widget_compositor_unittest.cc:132:
settings->single_thread_proxy_scheduler = false;
On 2015/01/27 01:46:37, danakj wrote:
> You could add a function to CompositorDependencies and have this test's
> FakeCompositorDependencies return the right value? That'd build on what we
have
> instead of making another way for tests to change things.

Done.  PTAL.

[danakj, 2015-01-27 03:40:46]

LGTM

[jbauman, 2015-01-27 03:42:42]

lgtm (though you'll probably need another owner now).

[enne (OOO), 2015-01-27 04:02:51]

enne@chromium.org changed reviewers:
+ sievers@chromium.org

[enne (OOO), 2015-01-27 04:03:02]

sievers: content/ OWNERS

[no sievers, 2015-01-27 19:26:59]

lgtm

https://codereview.chromium.org/871743002/diff/40001/content/renderer/gpu/com...
File content/renderer/gpu/compositor_dependencies.h (right):

https://codereview.chromium.org/871743002/diff/40001/content/renderer/gpu/com...
content/renderer/gpu/compositor_dependencies.h:38: virtual bool
UseSingleThreadScheduler() = 0;
Does this deserve a comment that this setting is only relevant in
single-threaded mode?

[enne (OOO), 2015-01-27 19:30:44]

https://codereview.chromium.org/871743002/diff/40001/content/renderer/gpu/com...
File content/renderer/gpu/compositor_dependencies.h (right):

https://codereview.chromium.org/871743002/diff/40001/content/renderer/gpu/com...
content/renderer/gpu/compositor_dependencies.h:38: virtual bool
UseSingleThreadScheduler() = 0;
On 2015/01/27 19:26:59, sievers wrote:
> Does this deserve a comment that this setting is only relevant in
> single-threaded mode?

Done.

[enne (OOO), 2015-01-27 19:30:51]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2015-01-27 19:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/871743002/60001

[commit-bot: I haz the power, 2015-01-27 21:23:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-27 21:24:21]

Patchset 4 (id:??) landed as
https://crrev.com/5232fbbf8df7e06471950a12bc041c766e31a997
Cr-Commit-Position: refs/heads/master@{#313357}