Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
index eb4e19115a48b0e8eff025950c2440d259ba8c5c..30577debe8226c18a987f9464bc24e57ad47f1cc 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc
@@ -21,6 +21,9 @@ NativeTabContentsContainerWin::NativeTabContentsContainerWin(
TabContentsContainer* container)
: container_(container) {
set_id(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW);
+ // We need to be focusable when our contents is not a view hierarchy, as
+ // clicking on the contents needs to focus us.
+ set_focusable(container_->tab_contents() != NULL);
}
NativeTabContentsContainerWin::~NativeTabContentsContainerWin() {
@@ -105,12 +108,6 @@ bool NativeTabContentsContainerWin::SkipDefaultKeyEventProcessing(
!container_->tab_contents()->is_crashed();
}
-bool NativeTabContentsContainerWin::IsFocusable() const {
- // We need to be focusable when our contents is not a view hierarchy, as
- // clicking on the contents needs to focus us.
- return container_->tab_contents() != NULL;
-}
-
void NativeTabContentsContainerWin::OnFocus() {
if (container_->tab_contents())
container_->tab_contents()->Focus();

Powered by Google App Engine
This is Rietveld 408576698