Chromium Code Reviews
DescriptionRevert 184783 "The link should be activated by enter key on focus.."
Revert sub patch 185540 "Fixing crash with sig: blink::HTMLAnchorElement::defaultEventHandle"
This patch affects the working with the enter key combined with
Ctrl, Ctrl+Shift and Alt keys. So we can't see to open the new
window or tab. Because this CL changed to simulate the click
when triggering the key press event.
But DOML3 events spec REQUIRES the click to occur on the
keydown event. Also keypress is defined to fire "if and only if
that key normally produces a character value".
First we revert this CL, then we should reconsider the original
bug with form element's hehavior.
Revert 184783
> The link should be activated by enter key on focusing the child element inside the anchor.
> The handing of Enter key has moved from keydown to keypress in anchor element.
> And this makes behavior consistent with Firefox and IE.
>
> BUG=350738, 425859
> R=pdr@chromium.org
> R=rob@robwu.nl
> TEST=LayoutTests/fast/events/keydown-enter-key-on-focused-element-inside-link.html
>
> Review URL: https://codereview.chromium.org/619613005
Revert 185540
> Fixing crash with sig: blink::HTMLAnchorElement::defaultEventHandle
>
> Rather than using the assert, I've added NULL-check because a target
> of event can be null.
>
> BUG=433542
> R=pdr@chromium.org
> TEST=LayoutTests/fast/events/anchor-ontransitionend-crash.html
BUG=451060, 350738, 433542
R=pdr@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189541
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 9 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||