Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 896383002: Revert 184783 "The link should be activated by enter key on focus.." (Closed)

Created:
5 years, 10 months ago by Miyoung Shin(g)
Modified:
5 years, 10 months ago
Reviewers:
pdr.
CC:
blink-reviews, ed+blinkwatch_opera.com, krit, blink-reviews-html_chromium.org, kouhei+svg_chromium.org, fs, dglazkov+blink, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert 184783 "The link should be activated by enter key on focus.." Revert sub patch 185540 "Fixing crash with sig: blink::HTMLAnchorElement::defaultEventHandle" This patch affects the working with the enter key combined with Ctrl, Ctrl+Shift and Alt keys. So we can't see to open the new window or tab. Because this CL changed to simulate the click when triggering the key press event. But DOML3 events spec REQUIRES the click to occur on the keydown event. Also keypress is defined to fire "if and only if that key normally produces a character value". First we revert this CL, then we should reconsider the original bug with form element's hehavior. Revert 184783 > The link should be activated by enter key on focusing the child element inside the anchor. > The handing of Enter key has moved from keydown to keypress in anchor element. > And this makes behavior consistent with Firefox and IE. > > BUG=350738, 425859 > R=pdr@chromium.org > R=rob@robwu.nl > TEST=LayoutTests/fast/events/keydown-enter-key-on-focused-element-inside-link.html > > Review URL: https://codereview.chromium.org/619613005 Revert 185540 > Fixing crash with sig: blink::HTMLAnchorElement::defaultEventHandle > > Rather than using the assert, I've added NULL-check because a target > of event can be null. > > BUG=433542 > R=pdr@chromium.org > TEST=LayoutTests/fast/events/anchor-ontransitionend-crash.html BUG=451060, 350738, 433542 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189541

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -104 lines) Patch
D LayoutTests/fast/events/anchor-ontransitionend-crash.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/events/anchor-ontransitionend-crash-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/events/press-enter-key-on-focused-element-inside-link.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/events/press-enter-key-on-focused-element-inside-link-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M LayoutTests/fast/events/simulated-key-state.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Miyoung Shin(g)
pdr@, PTAL
5 years, 10 months ago (2015-02-05 04:00:55 UTC) #1
pdr.
On 2015/02/05 at 04:00:55, myid.o.shin wrote: > pdr@, PTAL Please change the BUG line to ...
5 years, 10 months ago (2015-02-05 04:15:02 UTC) #2
Miyoung Shin(g)
On 2015/02/05 04:15:02, pdr wrote: > On 2015/02/05 at 04:00:55, myid.o.shin wrote: > > pdr@, ...
5 years, 10 months ago (2015-02-05 05:31:31 UTC) #3
pdr.
On 2015/02/05 at 05:31:31, myid.o.shin wrote: > On 2015/02/05 04:15:02, pdr wrote: > > On ...
5 years, 10 months ago (2015-02-05 05:34:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896383002/20001
5 years, 10 months ago (2015-02-05 05:38:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 10:14:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189541

Powered by Google App Engine
This is Rietveld 408576698